Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL-encoding not handled for proxy username.(http-client) #1779

Open
yangy-23 opened this issue Jul 30, 2024 · 0 comments
Open

URL-encoding not handled for proxy username.(http-client) #1779

yangy-23 opened this issue Jul 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@yangy-23
Copy link
Contributor

Describe the bug
Our Zscaler proxy requires @ to be used within the username. Because the username and password are specified as part of a URL, they must be URL-encoded by the caller; otherwise consider what would happen if the user's password or username contained an @ or a :, etc.

To Reproduce
Steps to reproduce the behavior:

  1. Self-hosted runner with http_proxy and https_proxy setup with user@name:password@proxy_url:proxy_port
  2. For URL encoding. The @ within http_proxy and https_proxy will be replaced with %40 for URL encoding
  3. http-client load the username as plain text without decoding

Expected behavior
Expect http-client decode username and password when needed.

Screenshots
Screenshot 2024-07-30 at 15 15 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant