-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favor local node installation if it matches with: node-version
option
#788
Comments
with node-version
option
with node-version
optionwith: node-version
option
Hello @dorsegal. Thank you for your report. Could you please share the logs ? The default behaviour for setup-node it to use node from the hosted toolcache. If it persists there setup-node should not reinstall it again. |
This took 10 minutes...
|
Hello @dorsegal. Could you please to disable cache and enable debug for steps ? Besides, How often do you run setup-node from you self-hosted runner? Did you have preinstalled Nodejs 18 in the hosted toolcache directory? |
Few things about our environment. We use actions runner controller to provision runners in K8s. Each runner has ephemeral storage attach to when we setup the runner docker image we installed node 18 on it. I cannot use toolcache as it use LOG:
|
Hello @dorsegal. In this case I think it is an expected behaviour because the action firstly tries to set up Nodejs from the hosted toolcache directory. If it does not exist there it will try to find it in node-versions. But you use arm64 architecture that is why it tries to install it through the official Nodejs site. It is an expected behaviour that installation from the Nodejs site takes more time. Regarding to the toolcache could you please try to change directory by specifying global environment variable |
Hello @dorsegal, just a gentle ping. |
We managed to get this working with our similar setup (using kubernetes and actions runner controller). We build our own image for the runners to use and managed to have success with the following in our
Permissions need another pass to get right but as a proof of concept it seems to be working:
We were struggling a bit where the underlying We didn't need to override the |
@dashford thank you it worked. I can see set-node pickup the node from cache. |
Description:
There are times when setup-node takes very long time (10m). I am using my own runner with node 18 installed.
It will be great if there will be a flag telling setup-node to just use the pre-installed node version if it matches the version that is installed.
Should looks something like this
Justification:
We are experiencing very slow run times just for this setup-node.
This approach can solve this. If people will use docker images with node pre installed.
#733
#726
The text was updated successfully, but these errors were encountered: