-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new granular cache actions #654
Comments
Hello @wmertens |
Hello @wmertens. I think it should not be implemented in scope of For now I'm going to close the issue. |
Hmm, wouldn't this functionality be 95% of use cases? Most of the time, you want your package manager of choice to run the install, and you want this to happen as fast as possible, and so you want caching? |
The setup-node action saves global cache directory for npm, yarn and pnpm that is why I think it does rely on the place where the cache will be saved. Moreover, the main purpose of the action is to setup Nodejs for images and adding extra logic to execute |
Description:
Actions/cache now supports choosing when to save and restore.
See actions/cache#1020 for a description.
So, setup-node can run the save automatically after packages install.
For that, the install command has to be called by setup-node as well.
It can be passed as an option, it can have a default (
npm ci
), and with corepack support #546 the defaults can be sensible, per package manager type.So then, most devs will just use this action with flags
cache
andinstall
and that's all they need to do.Justification:
Are you willing to submit a PR?
Maybe, but not now
The text was updated successfully, but these errors were encountered: