Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] output paths #1122

Open
ReenigneArcher opened this issue Aug 23, 2024 · 2 comments
Open

[request] output paths #1122

ReenigneArcher opened this issue Aug 23, 2024 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@ReenigneArcher
Copy link

ReenigneArcher commented Aug 23, 2024

Description:
Please add outputs to the action, such as npm-path. The setup-python action does this: https://github.com/actions/setup-python/blob/f677139bbe7f9c59b41e40162b753c062f5d49a3/action.yml#L34

At a minimum, printing the locations to the log would be helpful.

Justification:
I need to provide the npm path to CMake and this would make it convenient as it requires a full path.

Are you willing to submit a PR?

Yes, but I'm not familiar with the code base.

@ReenigneArcher ReenigneArcher added feature request New feature or request to improve the current logic needs triage labels Aug 23, 2024
@priya-kinthali
Copy link

Hello @ReenigneArcher 👋,
Thank you for this feature request. We will investigate it and get back to you as soon as we have some feedback.

@acnicholls
Copy link

acnicholls commented Aug 23, 2024

I would also like this. my user can't even execute node -v after the install as the PATH is not updated apparently...

I had the setup and usage in two different jobs, so the PATH was replaced. would still like to see it output for usage in future pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants