Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback cache keys #1120

Open
hyrious opened this issue Aug 14, 2024 · 1 comment
Open

Add fallback cache keys #1120

hyrious opened this issue Aug 14, 2024 · 1 comment
Labels
feature request New feature or request to improve the current logic

Comments

@hyrious
Copy link

hyrious commented Aug 14, 2024

Description:

Currently the cache key is always node-cache-{platform}-{packageManager}-{fileHash(lockfile)}, which means the cache is invalid if any one dependency changed. I want to achieve something like this restore-keys:

restore-keys: |
  npm-feature-${{ hashFiles('package-lock.json') }}
  npm-feature-
  npm-

Justification:

It would be very helpful if the same cache can be reused across many places even if their package.json has changed.

Are you willing to submit a PR?

I noticed that Yarn berry already has some logic about this, can we expand that use cases to all package managers?

@hyrious hyrious added feature request New feature or request to improve the current logic needs triage labels Aug 14, 2024
@priyagupta108
Copy link
Contributor

Hi @hyrious 👋,
Thank you for the feature request. We'll investigate it and get back to you as soon as we have updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants