Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache integration between actions/setup-java and actions/cache / actions/cache/restore #597

Open
caquino opened this issue Feb 14, 2024 · 1 comment
Labels
feature request New feature or request to improve the current logic

Comments

@caquino
Copy link

caquino commented Feb 14, 2024

Description:
Expose cache-primary-key as an output to allow integration with actions/cacheand actions/cache/restore.

Justification:
Caching rules differ according to the build tool used (mvn/sbt/etc), and I would like to leverage the logic already implemented on actions/setup-java to handle the specifics for each build tool.

That being said, I have dependent jobs that I would like to guarantee that the same cache is used by forcing the same cache key.

I understand that any advanced cache usage should be done manually using actions/cache, but just exposing the cache key used by actions/setup-java as an output, like cache-hit, would make it possible to extend the functionality from actions/setup-java.

Another possibility would be for actions/setup-java not only to set an output with the cache key but also to accept an input cache-key, but I think this goes into the realm of "should be done using actions/cache".

Are you willing to submit a PR?

My understanding is that a small change here to set an output, and to action.yml to declare the output, would suffice.
I would be more than happy to submit a PR, but before doing so, I would like to check with the team to see if this aligns with the vision for the future.

@caquino caquino added feature request New feature or request to improve the current logic needs triage labels Feb 14, 2024
@caquino caquino changed the title Cache integration between actions/setup-java and actions/cache/actions/cache/restore Cache integration between actions/setup-java and actions/cache / actions/cache/restore Feb 14, 2024
@HarithaVattikuti
Copy link
Contributor

Hello @caquino
Thank you for creating this feature request. We will investigate it and get back to you as soon as we have some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants