Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input property that would configure if the JDK should be configured as default or not #560

Open
vlsi opened this issue Nov 27, 2023 · 1 comment
Labels
feature request New feature or request to improve the current logic needs eyes

Comments

@vlsi
Copy link

vlsi commented Nov 27, 2023

Description:

Currently, setup-java configures the installed Java as default, however, there are cases when no change in JAVA_HOME is needed.

I suggest adding configure-as-default boolean input field (default true) so users could opt-out of configuring the installed Java for the default one.

Justification:

https://github.com/oracle-actions/setup-java downloads java binary, and it then calls actions/setup-java to set it up.

I use oracle-actions/setup-java to fetch Java EA (e.g. Java 22). I do not want Java 22 to be set as default since it would fail the build (e.g. Gradle does not yet support running with Java 22).
I need Java 22 for tests only, so I want Java 22 to be present, however, I would like to keep JAVA_HOME untouched.

Are you willing to submit a PR?

Maybe

@vlsi vlsi added feature request New feature or request to improve the current logic needs triage labels Nov 27, 2023
@IvanZosimov
Copy link
Contributor

Hi, @vlsi 👋 Thanks for the feature request! We will take a look and let you know about our decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic needs eyes
Projects
None yet
Development

No branches or pull requests

2 participants