Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support global.json's rollForward latest* variants #538

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

js6pak
Copy link

@js6pak js6pak commented Jul 20, 2024

Description:
This PR is a cleaned up version of #481, which fixes 2 issues:

  1. In the original npm run build wasn't rerun so dist is stale there
  2. The tests that were added never passed successfully

There are 3 additional commits in this PR:

  1. b4737b4 which fixes the 6 minute delay on windows runners caused by clear-toolcache.ps1
  2. 18b9c2a which makes sure the Uses an up to date bash download script test passes
  3. 3f75cd0 makes sure tests run even before the PR workflow is manually accepted, this can be dropped if needed

Related issue:
Fixes #448, closes #481

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

js6pak and others added 4 commits July 21, 2024 00:46
This further enhances time savings seen in actions#213, down from a few minutes to seconds.
This means you are going to be notified of CI issues quicker, especially if you have to wait for a confirmation before running the workflows on your PR.
@js6pak js6pak requested a review from a team as a code owner July 20, 2024 22:55
@js6pak
Copy link
Author

js6pak commented Aug 6, 2024

@HarithaVattikuti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script crashes when rollForward feature is set to latestMinor
2 participants