Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript errors and NPM workspaces #146

Open
chriscarpenter12 opened this issue Mar 13, 2024 · 0 comments · May be fixed by #147
Open

Typescript errors and NPM workspaces #146

chriscarpenter12 opened this issue Mar 13, 2024 · 0 comments · May be fixed by #147

Comments

@chriscarpenter12
Copy link

While starting to look at the possibility of creating our own hook for using KubeVirt I had pulled this repo down and saw some typescript errors. It would also be quite easy to use NPM workspaces with the current structure and to be able to hoist dependencies.

Would you be open to a PR to fix these?
chriscarpenter12 added a commit to chriscarpenter12/runner-container-hooks that referenced this issue Mar 13, 2024
@chriscarpenter12
Switch to npm workspaces and cleaned up typescript errors (actions#146)
c77d5bc
@chriscarpenter12 chriscarpenter12 linked a pull request Mar 13, 2024 that will close this issue
Open
chriscarpenter12 added a commit to chriscarpenter12/runner-container-hooks that referenced this issue Mar 13, 2024
@chriscarpenter12
Renames kind config sample to ignore local kind customizations (actio…
b67f446 
…ns#146)
chriscarpenter12 added a commit to chriscarpenter12/runner-container-hooks that referenced this issue Mar 13, 2024
@chriscarpenter12
Renames kind config sample to ignore local kind customizations (actio…
162143d 
…ns#146)
chriscarpenter12 added a commit to chriscarpenter12/runner-container-hooks that referenced this issue Mar 14, 2024
@chriscarpenter12
Switch to npm workspaces and cleaned up typescript errors (actions#146)
87f0c7b
chriscarpenter12 added a commit to chriscarpenter12/runner-container-hooks that referenced this issue Mar 14, 2024
@chriscarpenter12
Renames kind config sample to ignore local kind customizations (actio…
ee823e2 
…ns#146)
chriscarpenter12 added a commit to chriscarpenter12/runner-container-hooks that referenced this issue Mar 14, 2024
@chriscarpenter12
Switch to npm workspaces and cleaned up typescript errors (actions#146)
99a6440
chriscarpenter12 added a commit to chriscarpenter12/runner-container-hooks that referenced this issue Mar 14, 2024
@chriscarpenter12
Renames kind config sample to ignore local kind customizations (actio…
3d619d8 
…ns#146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@chriscarpenter12