-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans to support SSE (the future)? #10
Comments
I think that SSE would need to be handled entirely differently from the way this library works, because SSE does not use UPGRADE requests to open websockets. My quick read on this is that an absinthe SSE library could be a separate cowboy dispatcher. I see that there are some examples of how to implement SSE in cowboy, and a custom dispatcher can be registered. In any case, I think that it would be a different library. |
Would you know why the example code you referred to https://hexdocs.pm/phoenix/Phoenix.Endpoint.Cowboy2Adapter.html#module-custom-dispatch-options is not to be found in this lib https://github.com/mustafaturan/sse/blob/9edc7bc2397fb618861f15edb0a9ffd9ff8bb59e/README.md#phoenix-framework ? How is it running without the dispatcher? |
It looks like that readme is written more around running plug directly in Cowboy, without Phoenix involved at all. I was assuming that since you were using |
It seems that Absinthe.Plug uses SSE here: |
https://github.com/enisdenjo/graphql-sse/blob/master/PROTOCOL.md
https://www.the-guild.dev/blog/graphql-over-sse
The text was updated successfully, but these errors were encountered: