Fix TextField line breaking and text scrolling #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dimabory
reviewed
Oct 2, 2020
dimabory
reviewed
Oct 2, 2020
|
Seems to be a bit broken still: const { TextField } = require('precise-ui');
<TextField multiline resizable label="Test label" />
UPD: This is broken in the previous version as well. @Saladinek If you find out a solution in that PR, it would be great. |
dimabory
reviewed
Oct 6, 2020
There was a problem hiding this comment.
Could you determine the reason for the following changes?
- integration/image_snapshots/Anchor_3-snap.png
A background has been changed a little bit.
- integration/image_snapshots/AutocompleteTagBuilder_5-snap.png
- integration/image_snapshots/Autocomplete_3-snap.png
- integration/image_snapshots/DropdownField_3-snap.png
- integration/image_snapshots/DropdownField_7-snap.png
- integration/image_snapshots/DropdownField_9-snap.png
- integration/image_snapshots/DropdownSelect_3-snap.png
- integration/image_snapshots/DropdownSelect_7-snap.png
- integration/image_snapshots/DropdownSelect_9-snap.png
- integration/image_snapshots/PasswordField_1-snap.png
- integration/image_snapshots/SearchField_1-snap.png
- integration/image_snapshots/SearchField_3-snap.png
- integration/image_snapshots/SearchField_5-snap.png
- integration/image_snapshots/TextField_25-snap.png
- integration/image_snapshots/TextField_27-snap.png
- integration/image_snapshots/TextField_3-snap.png
- integration/image_snapshots/TextField_5-snap.png
A label size has been changed.
- integration/image_snapshots/Flyout_11-snap.png
- integration/image_snapshots/Form_5-snap.png
- integration/image_snapshots/RadioButtonGroup_1-snap.png
- integration/image_snapshots/RadioButtonGroup_11-snap.png
- integration/image_snapshots/RadioButtonGroup_5-snap.png
- integration/image_snapshots/RadioButtonGroup_7-snap.png
- integration/image_snapshots/RadioButtonGroup_9-snap.png
- integration/image_snapshots/RadioButtonGroup_1-snap.png
- integration/image_snapshots/RadioButtonGroup_11-snap.png
- integration/image_snapshots/RadioButtonGroup_13-snap.png
- integration/image_snapshots/RadioButtonGroup_3-snap.png
- integration/image_snapshots/RadioButtonGroup_7-snap.png
- integration/image_snapshots/RadioButtonGroup_9-snap.png
An indentation (probably padding) for elements has been changed.
PS: the best is to not introduce any BC (breaking changes).
|
it looks like a big issue ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
Fixes #305