Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-styleguidist #255

Open
dimabory opened this issue Feb 12, 2020 · 0 comments
Open

Upgrade react-styleguidist #255

dimabory opened this issue Feb 12, 2020 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file kitchen sink Concerns the official website

Comments

@dimabory
Copy link
Collaborator

dimabory commented Feb 12, 2020

New Feature Proposal

Description

I suggest upgrading react-styleguidist to use all new features along with other optimizations. The current version used by precise-ui is ^8.0.6, which kinda out-of-date. The latest stable is 10.6.1. The current version also contains a vulnerability issue:

                       === npm audit security report ===                        
                                                                                
# Run  npm install --save-dev [email protected]  to resolve 1 vulnerability
SEMVER WARNING: Recommended action is a potentially breaking change
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Cross-Site Scripting                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ serialize-javascript                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ react-styleguidist [dev]                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ react-styleguidist > copy-webpack-plugin >                   │
│               │ serialize-javascript                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1426                            │
└───────────────┴──────────────────────────────────────────────────────────────┘

found 1 moderate severity vulnerability in 3000232 scanned packages
  1 vulnerability requires semver-major dependency updates.

Background

  • adds the opportunity to use new features;
  • fixes vulnerability issue;
  • improves DX (easily to read docs for the last version);
  • brings build time optimizations;
  • gives the picture that the project is constantly maintaining;

UI

The kitchen sink may change the UI a little bit.

@dimabory dimabory added kitchen sink Concerns the official website dependencies Pull requests that update a dependency file labels Feb 12, 2020
@dimabory dimabory self-assigned this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kitchen sink Concerns the official website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant