Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borderless and clearable props broken on Autocomplete, borderless also broken on TagBuilder #239

Open
5 tasks done
Saladinek opened this issue Jan 31, 2020 · 1 comment
Open
5 tasks done
Labels
bug Something isn't working

Comments

@Saladinek
Copy link
Contributor

Saladinek commented Jan 31, 2020

Bug Report

Prerequisites

  • Can you reproduce the problem in a MWE?
  • Are you running the latest version?
  • Did you check the FAQs to see if that helps you?
  • Are you reporting to the correct repository?
  • Did you perform a search in the issues?

For more information, see the CONTRIBUTING guide.

Versions

You can get this information from executing npm version.

Description

Autocomplete component:

  • has clearable prop always set to true

  • does not properly remove border when borderless is set to true

TagBuilder component:

  • does not properly remove border when borderless is set to true

Steps to Reproduce

Clearable:

  1. Go to KitchenSink
  2. Set the Autocomplete prop clearable to false

Expected Behaviour: Autocomplete does not have the icon on the right side to delete values
Actual Behaviour: Autocomplete can still be cleared via the available icon

Borderless:

  1. Go to KitchenSink for Autocomplete or TagBuilder
  2. Set the property borderless to true

Expected Behaviour: There is no border shown on hover, error, existing value or when focused
Actual Behaviour: Border is not shown only when there is error with no input value. Border is shown when focused, hovering or has value.

Environment details: [OS, Browser, ...]

Possible Solution

Solution on hold

@Saladinek
Copy link
Contributor Author

Is the borderless property supposed to remove all borders (onHover, when value/error is set)?

@FlorianRappl FlorianRappl added the bug Something isn't working label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants