Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't ask the requests client to follow redirects #494

Open
abompard opened this issue Sep 30, 2024 · 0 comments
Open

Can't ask the requests client to follow redirects #494

abompard opened this issue Sep 30, 2024 · 0 comments

Comments

@abompard
Copy link

According to the documentation, it should be possible to ask Bravado to follow HTTP redirects using the _request_options parameter. Unfortunately, RequestConfig doesn't know about it and follow_redirect ends up in RequestConfig.additional_parameters which isn't used anywhere.
And then, RequestsClient.separate_params will try to find the follow_redirects option inside the requests params, which will never be there because requests_params only contains the parameters included in the Swagger spec, and will thus set it to False.

I think the detection of follow_redirects should be removed from RequestsClient.separate_params and added to RequestConfig instead.
abompard added a commit to fedora-infra/fasjson-client that referenced this issue Sep 30, 2024
@abompard
Follow redirects by default
7fc652d 
This is made harder by Yelp/bravado#494
It is necessary because of gssapi/mod_auth_gssapi#316

Signed-off-by: Aurélien Bompard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abompard