Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<dialog> "modal" boolean attribute #621

Open
WebWeWantBot opened this issue May 6, 2023 · 0 comments
Open

<dialog> "modal" boolean attribute #621

WebWeWantBot opened this issue May 6, 2023 · 0 comments

Comments

@WebWeWantBot
Copy link


title: "modal" boolean attribute
date: 2023-05-06T06:10:30.702Z
submitter: Jiyoung Joung
number: 6455ef56496486005d09cc9f
tags: [ ]
discussion: https://github.com/WebWeWant/webwewant.fyi/discussions/
status: [ discussing || in-progress || complete ]
related:

  • title:
    url:
    type: [ article || explainer || draft || spec || note || discussion ]

It is for the consistence of show() and showModal(). When I declare the modal dialog, you just type:

<dialog modal="modal">
   <!--something content...-->
</dialog>

or when you open the dialog by javascript, you just type:

const dialog = document.querySelector('dialog');
dialog.show( { modal: true } )

It would be nicer to declare "modal boolean attribute" because we will be able to open dialog by only one function(show()).


If posted, this will appear at https://webwewant.fyi/wants/6455ef56496486005d09cc9f/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant