Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why lock WETH Interface at Solidity 0.8.15? #395

Open
tomw1808 opened this issue Jul 23, 2024 · 0 comments
Open

Why lock WETH Interface at Solidity 0.8.15? #395

tomw1808 opened this issue Jul 23, 2024 · 0 comments

Comments

@tomw1808
Copy link

I hope I am not overstepping here with the question, but why lock at exactly 0.8.15 and not make it compatible to versions >= 0.8.0 and at least <= 0.8.26 (current) so that it works across other contracts too without needing to compile with different solc versions?

Especially in the mix with Openzeppelin contracts, OZ proxies and other libraries, its somehow strange to have this one locked in at 0.8.15, while most other contracts are actually >= 0.7.x and work just fine with any 0.8.x as well. Yes, the obvious work around is to make a local copy - however, before doing that, I just want to make sure I'm not missing anything.

So the question: Was there a specific reason to lock it exactly at version 0.8.15?

And, if no, the follow-up question: Creating a PR and changing the version to >=0.8.0 and <= 0.8.26, how are the chances this will get approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant