You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, according to #198, the solc version of PositionValue is restricted below 0.8.0, as fee calculation code relies on unchecked math that is expected to overflow. Current implementation is pragma solidity >=0.6.8 <0.8.0;.
But in 0.8 branch, PositionValue has no unchecked nor the code is altered, but the version 0.8.0 is included.
Thus unexpected revert will happen as I am understanding it correctly.
The text was updated successfully, but these errors were encountered:
Hi, according to #198, the solc version of
PositionValue
is restricted below 0.8.0, as fee calculation code relies on unchecked math that is expected to overflow. Current implementation ispragma solidity >=0.6.8 <0.8.0;
.But in 0.8 branch, PositionValue has no
unchecked
nor the code is altered, but the version0.8.0
is included.Thus unexpected revert will happen as I am understanding it correctly.
The text was updated successfully, but these errors were encountered: