-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INonfungiblePositionManager import openzeppelin IERC721Metadata #335
Comments
They have it in 0.8 branch, but never finished the migration I assume. |
What should I do? |
Hi, did you find a solution for this problem? I am facing the same Thakn you |
1.copy INonfungiblePositionManager.sol to you project,dont use @uniswap/v3-periphery/contracts/interfaces/INonfungiblePositionManager.sol |
It's because there's a mismatch between the open-zeppelin version that this project uses and our own (old) version. import '@openzeppelin/contracts/token/ERC721/IERC721Metadata.sol'; Imports like this in the contract break because it tries to look at the package relative to your node-modules, while this project has it's own node_modules folder it tries to import from. I guess we're left to patchwork imports together as needed. EDIT: Doensn't look like there's a reason from looking through the issues. Just nobody has done it yet. |
The imports of openzeppelin IERC721Metadata and IERC721Enumerable into INonfungiblePositionManager is broken since OpenZeppelin moved these two interfaces into the extensions folder.
Error HH404: File @openzeppelin/contracts/token/ERC721/IERC721Metadata.sol, imported from @uniswap/v3-periphery/contracts/interfaces/INonfungiblePositionManager.sol, not found.
The text was updated successfully, but these errors were encountered: