Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INonfungiblePositionManager import openzeppelin IERC721Metadata #335

Open
Seesaem opened this issue Feb 15, 2023 · 5 comments
Open

INonfungiblePositionManager import openzeppelin IERC721Metadata #335

Seesaem opened this issue Feb 15, 2023 · 5 comments

Comments

@Seesaem
Copy link

Seesaem commented Feb 15, 2023

The imports of openzeppelin IERC721Metadata and IERC721Enumerable into INonfungiblePositionManager is broken since OpenZeppelin moved these two interfaces into the extensions folder.

Error HH404: File @openzeppelin/contracts/token/ERC721/IERC721Metadata.sol, imported from @uniswap/v3-periphery/contracts/interfaces/INonfungiblePositionManager.sol, not found.

@boris-lapouga
Copy link

They have it in 0.8 branch, but never finished the migration I assume.

@tiantianlikeu
Copy link

What should I do?

@ShivaliLN
Copy link

Hi, did you find a solution for this problem? I am facing the same Thakn you

@tiantianlikeu
Copy link

Hi, did you find a solution for this problem? I am facing the same Thakn you

1.copy INonfungiblePositionManager.sol to you project,dont use @uniswap/v3-periphery/contracts/interfaces/INonfungiblePositionManager.sol
2. you just need interface function and struct ,remove unwanted integrations and references

@NotCoffee418
Copy link

NotCoffee418 commented Aug 18, 2024

It's because there's a mismatch between the open-zeppelin version that this project uses and our own (old) version.

import '@openzeppelin/contracts/token/ERC721/IERC721Metadata.sol';

Imports like this in the contract break because it tries to look at the package relative to your node-modules, while this project has it's own node_modules folder it tries to import from.
Fix is upgrading open-zeppelin in this project to the latest version and adjusting imports, but I'm guessing there's a good reason that's not being done.

I guess we're left to patchwork imports together as needed.

EDIT: Doensn't look like there's a reason from looking through the issues. Just nobody has done it yet.
See #377 for closest relevant issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants