Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExclusiveDutchOrders are returned from endpoint but are labelled Dutch orders #295

Open
nhtyy opened this issue Jul 19, 2023 · 1 comment

Comments

@nhtyy
Copy link

nhtyy commented Jul 19, 2023

caused confusion

you can try decoding this in solidity, or you can see that "4ef5ed7a01e37cb578f497329cdb3c273a50000000000000000000000000000000000000000000000000000000000002710"
in the encoded_order field is the exclusive filler / bp override, which shouldnt exist on a dutch order type!

ex mislabbled

OrderResponseInner {
            order_type: Dutch,
            order_status: Open,
            chain_id: 1,
            encoded_order: "0x000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000001200000000000000000000000000000000000000000000000000000000064b523ba0000000000000000000000000000000000000000000000000000000064b523ba000000000000000000000000b507d4ef5ed7a01e37cb578f497329cdb3c273a50000000000000000000000000000000000000000000000000000000000002710000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc20000000000000000000000000000000000000000000000000214e8348c4f00000000000000000000000000000000000000000000000000000214e8348c4f00000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000e80bf394d190851e215d5f67b67f8f5a52783f1e000000000000000000000000b8bff65b2eeb60d6b37312ca0740a742d5e7f95500000000000000000000000000000000000000000000000000000189637cabd70000000000000000000000000000000000000000000000000000000064b523ba000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000002260fac5e5542a773aa44fbcfedf7c193bc2c599000000000000000000000000000000000000000000000000000000000009cac4000000000000000000000000000000000000000000000000000000000009cac4000000000000000000000000b8bff65b2eeb60d6b37312ca0740a742d5e7f955",
            signature: "0x8a984da0ab70e1fca93ca8d2c7845d3cad76b437372840521855a4c2cc72d12f285ab3aeb51dd41845bfa73c7b89cb954d2d995dbb8162976a0d9acd6d0de33e1b",
            order_hash: "0x4568c1ed3ce7d3135c6f424fd9a7ad772e4d8a7eba67ca90265f6e2177dd7311",
            created_at: 1689591263,
            input: OrderInput {
                token: "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2",
                start_amount: Some(
                    "150000000000000000",
                ),
                end_amount: Some(
                    "150000000000000000",
                ),
            },
            outputs: [
                OrderOutput {
                    token: "0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599",
                    start_amount: Some(
                        "641732",
                    ),
                    end_amount: Some(
                        "641732",
                    ),
                    recipient: Some(
                        "0xb8bff65b2eeb60d6b37312ca0740a742d5e7f955",
                    ),
                },
            ],
        },
@nhtyy
Copy link
Author

nhtyy commented Jul 19, 2023

https://github.com/Uniswap/uniswapx-sdk/blob/main/src/order/DutchOrder.ts

prob downsteam of this being for exclusive dutch..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant