Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

percents start loop index #591

Open
guotie opened this issue Jun 4, 2024 · 0 comments
Open

percents start loop index #591

guotie opened this issue Jun 4, 2024 · 0 comments

Comments

@guotie
Copy link

guotie commented Jun 4, 2024

https://github.com/Uniswap/smart-order-router/blob/14815de0ee93f4abc9ad16e6a723ec185e6f15d8/src/routers/alpha-router/functions/best-swap-route.ts#L238C16-L238C32

should here be

for (let i = percents.length - 1; i >= 0; i--) {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guotie