Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use Assembly.LoadFrom ? #2631

Open
fm-117 opened this issue Jun 13, 2024 · 0 comments
Open

Do not use Assembly.LoadFrom ? #2631

fm-117 opened this issue Jun 13, 2024 · 0 comments

Comments

@fm-117
Copy link
Contributor

fm-117 commented Jun 13, 2024

The class ExtensionManager uses Assembly.LoadFrom to load extensions identified by their assembly file path. This method may lead to duplicate assemblies loaded in same context.

A better option would be to use Assembly.Load and subscribe to the AppDomain.AssemblyResolve event to actually tell the runtime to select the correct file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fm-117