-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide the fate of VarInfo.num_produce
#661
Comments
@yebai should also probably have a look at this 👍 |
We could move this to Each |
@mhauru, do you want to try this? I'm happy to help you through the process if you have any questions. |
For reference, the only place that we use the Lines 1716 to 1719 in 24a7380
which is called by a function in Turing, Particle MCMC samplers use this to remove obsolete random variables in |
Can do. Will take me a moment though, I'll have to start by reading some wikipedia to get a basic idea of what particle MCMC does. |
I thought I'd write more about The In the DynamicPPL code, we delete random variable |
This is a feature of
VarInfo
that's only used by particle samplers. Having it stored inVarInfo
doesn't feel like the right place, and we would like to get rid of it when we refactorVarInfo
/SimpleVarInfo
. However, having the sampler keep track of it is apparently not easy either, and might require changes to how some contexts work around samplers. We could also drop it, but that would mean losing existing particle sampler functionality.Discussed with @torfjelde, @sunxd3, and @willtebbutt.
The text was updated successfully, but these errors were encountered: