Move predict from Turing, implemented using fix
#651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11609937314Details
💛 - Coveralls |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #651 +/- ##
==========================================
- Coverage 79.23% 77.34% -1.89%
==========================================
Files 30 30
Lines 4214 3947 -267
==========================================
- Hits 3339 3053 -286
- Misses 875 894 +19 ☔ View full report in Codecov by Sentry. |
|
This approach currently has issues. See #702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #647
Turing's implementation relies on
setval_and_resample!to generate the predictions, and usebundle_samplesfunction implemented inTuring.Inference.This PR provides a draft implementing
predictusing the newfixinterface: given a sample from the posterior, we can fix the values of model parameters with the posterior sample, then just generate one sample from prior.This doesn't work yet.