-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap for depreciating VarInfo
in favour of SimpleVarInfo
#416
Comments
IIRC we don't use GID etc in the Gibbs sampler anymore. |
Are you referring to |
I think that's done solely by the sub-samplers and their parameter space (eg https://github.com/TuringLang/Turing.jl/blob/9f8a9c4c476095d45246b4924d5cd542f3f8d506/src/inference/gibbs.jl#L243)? The logic was changed quite a bit in TuringLang/Turing.jl#1500. |
Exactly what I was referring to yeah. And the current "selector" stuff for samplers IMO should go away, and we should instead keep track of which varnames correspond to which sampler in the |
@yebai we might want to move this issue to a discussion instead. In a discussion we can make sub-threads, which makes it much easier to keep track of the ongoing conversations regarding particular points rather than having a flat thread like in an issue. |
This is meant as an umbrella issue for documenting the steps required to depreciate
VarInfo
in favour ofSimpleVarInfo
-equivalwent.Some known items:
SimpleVarInfo
: solved byVarNamedVector
VarInfo
: solved bycondition
-based Gibbs samplerVarNamedVector
cc @torfjelde
The text was updated successfully, but these errors were encountered: