Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for depreciating VarInfo in favour of SimpleVarInfo #416

Open
3 of 4 tasks
yebai opened this issue Jul 5, 2022 · 5 comments
Open
3 of 4 tasks

Roadmap for depreciating VarInfo in favour of SimpleVarInfo #416

yebai opened this issue Jul 5, 2022 · 5 comments
Assignees

Comments

@yebai
Copy link
Member

yebai commented Jul 5, 2022

This is meant as an umbrella issue for documenting the steps required to depreciate VarInfo in favour of SimpleVarInfo-equivalwent.

Some known items:

  • Lineralisation for SimpleVarInfo: solved by VarNamedVector
  • Support for Gibbs sampling: e.g. GID stuff in VarInfo: solved by condition-based Gibbs sampler
  • Support for dynamic model sizes: solved by VarNamedVector
  • Support for particle MCMC samplers:

cc @torfjelde

@devmotion
Copy link
Member

Support for Gibbs sampling: e.g. GID stuff in VarInfo

IIRC we don't use GID etc in the Gibbs sampler anymore.

@torfjelde
Copy link
Member

IIRC we don't use GID etc in the Gibbs sampler anymore.

Are you referring to Gibbs or GibbsConditional? Because in the former I'm pretty sure it's used to determine which variables are related to which sampler.

@devmotion
Copy link
Member

I think that's done solely by the sub-samplers and their parameter space (eg https://github.com/TuringLang/Turing.jl/blob/9f8a9c4c476095d45246b4924d5cd542f3f8d506/src/inference/gibbs.jl#L243)? The logic was changed quite a bit in TuringLang/Turing.jl#1500.

@torfjelde
Copy link
Member

I think that's done solely by the sub-samplers and their parameter space

Exactly what I was referring to yeah. And the current "selector" stuff for samplers IMO should go away, and we should instead keep track of which varnames correspond to which sampler in the Gibbs sampler or something.

@torfjelde
Copy link
Member

@yebai we might want to move this issue to a discussion instead. In a discussion we can make sub-threads, which makes it much easier to keep track of the ongoing conversations regarding particular points rather than having a flat thread like in an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants