ghost/i18n/locales/sv/portal.json (1)

41-41: ⚠️ Potential issue

Regression: Previously translated strings are now empty.

The following strings have lost their Swedish translations:

• "Comment preferences updated."
• "Email preferences updated."
• "Signups from this email domain are currently restricted."

This appears to be an unintended regression that reduces the localization coverage.

Please restore the previous Swedish translations for these strings. If you need help finding the previous translations, I can help search through the git history.

Also applies to: 63-63, 142-142

ghost/i18n/locales/zh/portal.json (1)

114-115: ⚠️ Potential issue

Verify the removal of existing translations.

Several existing translations have been removed (set to empty strings). This might be unintentional and could impact the user experience for Chinese users. Please verify if these translations should be preserved:

• "No member exists with this e-mail address."
• "No member exists with this e-mail address. Please sign up first."
• Error messages for subscription and email operations

Also applies to: 166-169, 210-210

ghost/i18n/locales/ja/portal.json (1)

71-82: ⚠️ Potential issue

Verify the removal of existing translations.

Several existing translations have been removed (set to empty strings). This might be unintentional and could impact the user experience for Japanese users. Please verify if these translations should be preserved:

• Error messages for login, logout, and signup operations
• Error messages for account and subscription operations
• Error messages for email operations

Also applies to: 166-169, 210-210

ghost/i18n/locales/cs/portal.json (1)

67-68: ⚠️ Potential issue

Inconsistent translations for similar strings.

Some strings have translations while similar ones don't:

• "Enter your email address" is empty but "Invalid email address" has a translation
• "Enter your name" is empty but "Name" has a translation

Also applies to: 100-100

ghost/i18n/locales/de-CH/portal.json (1)

67-68: ⚠️ Potential issue

Inconsistent translations for similar strings.

Some strings have translations while similar ones don't:

• "Enter your email address" is empty but "Email" has a translation
• "Enter your name" is empty but "Name" has a translation

Also applies to: 100-100

ghost/i18n/locales/fr/portal.json (1)

41-41: 🛠️ Refactor suggestion

Missing translations for several user-facing strings in French locale.

The following strings need French translations to ensure a complete localization experience:

• "Comment preferences updated."
• "Email preferences updated."
• "Signups from this email domain are currently restricted."
• "This site only accepts paid members."
• "Too many sign-up attempts, try again later"

Also applies to: 63-63, 142-142, 172-172, 181-181

ghost/i18n/locales/sv/portal.json (1)

18-18: Swedish translation needed for the new donation field string.

The new string "Add a personal note" requires a Swedish translation to maintain localization coverage.

Would you like me to help find a native Swedish speaker to provide the translation? I can create an issue to track this task.

ghost/i18n/locales/ro/portal.json (1)

101-101: Consider removing or transliterating the example name.

The entry "Jamie Larson" appears to be a placeholder name. Consider either:

1. Removing it if not needed
2. Using a Romanian name that would be more familiar to Romanian users
3. Keeping it as is if it's a specific person's name that shouldn't be translated

ghost/i18n/locales/lt/portal.json (1)

1-215: Consider implementing a translation coverage check.

The file shows a pattern of missing translations for both new and existing strings. This could impact the user experience for Lithuanian users.

Consider implementing a CI check that:

1. Prevents removal of existing translations
2. Flags new strings without translations
3. Reports translation coverage percentage

Here's a script to check translation coverage:

#!/bin/bash
# Description: Check translation coverage in portal.json

# Count total number of translation keys
total_keys=$(cat ghost/i18n/locales/lt/portal.json | jq 'length')

# Count number of empty translations
empty_translations=$(cat ghost/i18n/locales/lt/portal.json | jq '[to_entries[] | select(.value == "")] | length')

# Calculate and display coverage
coverage=$((100 * (total_keys - empty_translations) / total_keys))
echo "Translation coverage: $coverage% ($empty_translations empty translations out of $total_keys keys)"

# List keys with empty translations
echo -e "\nKeys missing translations:"
cat ghost/i18n/locales/lt/portal.json | jq 'to_entries[] | select(.value == "") | .key'

ghost/payments/lib/PaymentsService.js (1)

125-125: Add JSDoc documentation for the personalNoteText parameter.

The method signature should include documentation for the new parameter to improve code maintainability.

Apply this diff to add documentation:

     /**
      * @param {object} params
      * @param {Member} [params.member]
      * @param {Object.<string, any>} [params.metadata]
      * @param {string} params.successUrl
      * @param {string} params.cancelUrl
      * @param {boolean} [params.isAuthenticated]
      * @param {string} [params.email]
+     * @param {string} [params.personalNoteText] Personal note to be displayed with the donation
      *
      * @returns {Promise<URL>}
      */

ghost/i18n/locales/he/portal.json (1)

1-216: Consider implementing a translation management system.

The changes consistently add new keys across all localization files, but managing translations manually across multiple files can be error-prone. Consider:

1. Implementing a translation management system to track missing translations
2. Adding a CI check to flag missing translations
3. Setting up a process to notify translators when new strings are added

Run this script to get an overview of translation coverage across all localization files:

#!/bin/bash
# Description: Generate a translation coverage report for all localization files
for file in ghost/i18n/locales/*/portal.json; do
  lang=$(echo $file | cut -d'/' -f4)
  total=$(jq 'length' $file)
  empty=$(jq 'to_entries | map(select(.value == "")) | length' $file)
  echo "Language: $lang"
  echo "Total strings: $total"
  echo "Empty translations: $empty"
  echo "---"
done

ghost/i18n/locales/ms/portal.json (1)

18-18: LGTM! Consider adding the English translation as a fallback.

The addition of the "Add a personal note" key follows the established pattern. While leaving it empty allows for future localization, consider adding the English text as a temporary fallback to ensure a good user experience until translations are provided.

-    "Add a personal note": "",
+    "Add a personal note": "Add a personal note",

ghost/i18n/locales/af/portal.json (1)

18-18: LGTM! Consider adding an Afrikaans translation.

The key has been added consistently. Since Afrikaans is similar to Dutch and English, a suggested translation would be "Voeg 'n persoonlike nota by".

-    "Add a personal note": "",
+    "Add a personal note": "Voeg 'n persoonlike nota by",

ghost/i18n/locales/pl/portal.json (1)

18-18: LGTM! Consider adding a Polish translation.

The key has been added consistently. A suggested Polish translation would be "Dodaj osobistą notatkę".

-    "Add a personal note": "",
+    "Add a personal note": "Dodaj osobistą notatkę",

ghost/i18n/locales/hu/portal.json (1)

18-18: LGTM! Consider adding a Hungarian translation.

The key has been added consistently. A suggested Hungarian translation would be "Személyes megjegyzés hozzáadása".

-    "Add a personal note": "",
+    "Add a personal note": "Személyes megjegyzés hozzáadása",

ghost/i18n/locales/bs/portal.json (1)

18-18: LGTM! Consider adding a Bosnian translation.

The key has been added consistently. A suggested Bosnian translation would be "Dodaj ličnu bilješku".

-    "Add a personal note": "",
+    "Add a personal note": "Dodaj ličnu bilješku",

ghost/i18n/locales/hi/portal.json (1)

1-216: Consider implementing a translation management system.

All localization files show a consistent pattern of missing translations for newly added strings. This suggests a need for a more streamlined translation process.

Consider implementing a translation management system that can:

1. Automatically identify missing translations
2. Notify translators when new strings are added
3. Track translation progress across all languages
4. Ensure consistency in translations

This would help maintain a high-quality localized experience across all supported languages.

ghost/i18n/locales/pt/portal.json (1)

18-18: LGTM! Key added consistently.

The new key "Add a personal note" has been added with an empty string value, ready for translation.

Would you like me to help provide the Portuguese translation for this string?

ghost/i18n/locales/el/portal.json (1)

18-18: LGTM! Key added consistently.

The new key "Add a personal note" has been added with an empty string value, ready for translation.

Would you like me to help provide the Greek translation for this string?

ghost/i18n/locales/no/portal.json (1)

18-18: LGTM! Key added consistently.

The new key "Add a personal note" has been added with an empty string value, ready for translation.

Would you like me to help provide the Norwegian translation for this string?

ghost/i18n/locales/ar/portal.json (1)

18-18: LGTM! Key added consistently.

The new key "Add a personal note" has been added with an empty string value, ready for translation. Since Arabic is a right-to-left (RTL) language, ensure the translation maintains proper RTL formatting when implemented.

Would you like me to help provide the Arabic translation for this string?

ghost/i18n/locales/vi/portal.json (1)

18-18: LGTM! Key added consistently.

The new key "Add a personal note" has been added with an empty string value, ready for translation.

Would you like me to help provide the Vietnamese translation for this string?

ghost/i18n/locales/it/portal.json (1)

1-216: Coordinate translations for the new donation personalization feature.

The new "Add a personal note" feature is missing translations in all localization files (ru, nl, da, bg, it). This will affect all non-English users trying to add personal notes to their donations.

Consider:

1. Coordinating with translators to provide translations for all supported languages before releasing the feature
2. Adding a translation tracking system to ensure new features maintain localization coverage
3. Setting up a process to prevent merging new features without corresponding translations

ghost/i18n/locales/uk/portal.json (1)

18-18: Track translations for the new personal note feature.

The key "Add a personal note" has been added across all localization files but currently lacks translations in multiple languages. Consider creating a tracking issue to ensure all translations are provided before the feature is released.

Would you like me to create a tracking issue for gathering translations for the new personal note feature?

ghost/i18n/locales/sk/portal.json (1)

18-18: Add Slovak translation for the personal note field.

The new key "Add a personal note" is missing its Slovak translation. This could affect the user experience for Slovak users when making donations.

Would you like me to help create an issue to track the missing translations? This would help ensure all localization strings are properly translated before release.

ghost/i18n/locales/sr/portal.json (1)

18-18: Add Serbian translation for the personal note field.

The new key "Add a personal note" is missing its Serbian translation. This could affect the user experience for Serbian users when making donations.

Would you like me to help create an issue to track the missing translations? This would help ensure all localization strings are properly translated before release.

ghost/i18n/locales/ko/portal.json (1)

18-18: Add Korean translation for the personal note field.

The new key "Add a personal note" is missing its Korean translation. This could affect the user experience for Korean users when making donations.

Would you like me to help create an issue to track the missing translations? This would help ensure all localization strings are properly translated before release.

ghost/i18n/locales/fi/portal.json (1)

18-18: Add Finnish translation for the personal note field.

The new key "Add a personal note" is missing its Finnish translation. This could affect the user experience for Finnish users when making donations.

Would you like me to help create an issue to track the missing translations? This would help ensure all localization strings are properly translated before release.

ghost/i18n/locales/nn/portal.json (2)

18-18: Add Norwegian Nynorsk translation for the personal note field.

The new key "Add a personal note" is missing its Norwegian Nynorsk translation. This could affect the user experience for Norwegian users when making donations.

Would you like me to help create an issue to track the missing translations? This would help ensure all localization strings are properly translated before release.

---

1-216: Consider a coordinated localization update for the donation feature.

The addition of the "Add a personal note" feature across all localization files is currently missing translations. To ensure a consistent user experience across all supported languages, consider:

1. Coordinating with translators to provide translations for all languages simultaneously
2. Adding a default English fallback for missing translations
3. Implementing string sanitization as mentioned in the PR objectives

To help track the progress of translations and ensure consistency, would you like me to help create a tracking issue that:

1. Lists all affected language files
2. Provides context about the donation feature
3. Includes sanitization requirements
4. Sets up a checklist for translation status

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: cathysarisky
PR: TryGhost/Ghost#22075
File: ghost/i18n/locales/pt-BR/portal.json:0-0
Timestamp: 2025-01-30T15:13:48.222Z
Learning: When reviewing translation files in i18n/locales/*, the keys (left side) must never be changed. If a translator has modified any keys, this should be flagged as a potential error requiring review or correction. Only the translation values (right side) should be modified.

Learnt from: cathysarisky
PR: TryGhost/Ghost#22075
File: ghost/i18n/locales/pt-BR/portal.json:0-0
Timestamp: 2025-01-30T15:13:48.222Z
Learning: When reviewing translation files in i18n/locales/*, the keys (left side) must never be changed. If a translator has modified any keys, this should be flagged as a potential error requiring review or correction. Only the translation values (right side) should be modified.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro