Skip to content

Latest commit

 

History

History
238 lines (187 loc) · 9.08 KB

CONTRIBUTING.md

File metadata and controls

238 lines (187 loc) · 9.08 KB
Raw

Contribution guide

First, thank you for contributing! We love and encourage pull requests from everyone. Please follow the guidelines:

  • Check the open issues and pull requests for existing discussions.

  • Open an issue first, to discuss a new feature or enhancement.

  • Write tests, and make sure the test suite passes locally.

  • Open a pull request, and reference the relevant issue(s).

  • Make sure your commits are logically separated and have good comments explaining the details of your change.

  • After receiving feedback, amend your commits or add new ones as appropriate.

  • Have fun!

Development Workflow

Start by forking the frostfs-testlib repository, make changes in a branch and then send a pull request. We encourage pull requests to discuss code changes. Here are the steps in details:

Set up your GitHub Repository

Fork FrostFS testlib upstream source repository to your own personal repository. Copy the URL of your fork and clone it:

$ git clone <url of your fork>

Set up git remote as upstream

$ cd frostfs-testlib
$ git remote add upstream https://github.com/TrueCloudLab/frostfs-testlib
$ git fetch upstream

Set up development environment

To setup development environment for frostfs-testlib, please, take the following steps:

  1. Prepare virtualenv
$ virtualenv --python=python3.10 venv
$ source venv/bin/activate
  1. Install all dependencies:
$ pip install -r requirements.txt
  1. Setup pre-commit hooks to run code formatters on staged files before you run a git commit command:
$ pre-commit install

Optionally you might want to integrate code formatters with your code editor to apply formatters to code files as you go:

  • isort is supported by PyCharm, VS Code. Plugins exist for other IDEs/editors as well.
  • black can be integrated with multiple editors, please, instructions are available here.

Create your feature branch

Before making code changes, make sure you create a separate branch for these changes. Maybe you will find it convenient to name branch in <type>/<issue>-<changes_topic> format.

$ git checkout -b feature/123-something_awesome

Test your changes

Before submitting any changes to the library, please, make sure that all unit tests are passing. To run the tests, please, use the following command:

$ python -m unittest discover --start-directory tests

To enable tests that interact with SSH server, please, setup SSH server and set the following environment variables before running the tests:

SSH_SHELL_HOST = <address of the server>
SSH_SHELL_LOGIN = <login that has permissions to run python3 on the server>
SSH_SHELL_PRIVATE_KEY_PATH = <path to SSH private key on your machine>
SSH_SHELL_PRIVATE_KEY_PASSPHRASE = <passphrase for the SSH private key>

Commit changes

After verification, commit your changes. There is a great post on how to write useful commit messages. Try following this template:

[#Issue] Summary
Description
<Macros>
<Sign-Off>

$ git commit -am '[#123] Add some feature'

Push to the branch

Push your locally committed changes to the remote origin (your fork):

$ git push origin feature/123-something_awesome

Create a Pull Request

Pull requests can be created via GitHub. Refer to this document for detailed steps on how to create a pull request. After a Pull Request gets peer reviewed and approved, it will be merged.

DCO Sign off

All authors to the project retain copyright to their work. However, to ensure that they are only submitting work that they have rights to, we are requiring everyone to acknowledge this by signing their work.

Any copyright notices in this repository should specify the authors as "the contributors".

To sign your work, just add a line like this at the end of your commit message:

Signed-off-by: Samii Sakisaka <[email protected]>

This can easily be done with the --signoff option to git commit.

By doing this you state that you can certify the following (from The Developer Certificate of Origin):

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or
(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or
(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.
(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Code Style

We use black and isort for code formatting. Please, refer to Black code style for details.

Type hints are mandatory for library's code:

  • class attributes;
  • function or method's parameters;
  • function or method's return type.

The only exception is return type of test functions or methods - there's no much use in specifying None as return type for each test function.

Do not use relative imports. Even if the module is in the same package, use the full package name.

To format docstrings, please, use Google Style Docstrings. Type annotations should be specified in the code and not in docstrings (please, refer to this sample).

Editable installation

If you would like to modify code of the library in the integration with your test suite, you can use editable installation. For that, in virtual environment of your test suite (not in the virtual environment of the testlib itself!) run the following command (path to frostfs-testlib directory might be different on your machine):

$ pip install -e ../frostfs-testlib

Maintaining guide

Versioning

We follow Semantic Versioning Specification to version this library. To manage version number in the source code, we use bumpver package.

To update a version of the library, please, take the following steps:

  1. Make sure that your have no pending changes in git.
  2. Run the following command to update version and commit it to git: 
    $ bumpver update --major   # to update major version
$ bumpver update --minor   # to update minor version
$ bumpver update --patch   # to update the patch component of the version
  3. Sign-off the created commit: 
    $ git commit --amend --signoff
  4. Push the changes to remote.
  5. After this commit is merged to upstream, create a tag on the master branch of upstream. Tag name should be formatted as "v{new_version}": 
    $ git tag v<new_version>
$ git push upstream v<new_version>

Building and publishing package

To build Python package of the library, please run the following command in the library root directory:

$ python -m build

This command will put wheel file and source archive under dist directory.

To check that package description will be correctly rendered at PyPI, please, use command:

$ twine check dist/*

To upload package to test PyPI, please, use command:

$ twine upload -r testpypi dist/*

It will prompt for your username and password. You would need to create test PyPI account in order to execute it.

To upload package to actual PyPI, please, use command:

$ twine upload dist/*

It will prompt for your username and password. You would need to create PyPI account in order to execute it.