You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All FrostFS contracts aside netmap have simple update routine which is defined in if isUpdate branch of _deploy function.
Netmap contract have mandatory system config update and it requires specific arguments format for update function.
It looks to me as outdated code and it would be nice to have more flexibility in update arguments format for netmap contract. So my propose is to move if isUpdate branch before argument parsing and setConfig call.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
discussionTalking about something in order to reach a decision or to exchange ideas
All FrostFS contracts aside netmap have simple update routine which is defined in
if isUpdate
branch of_deploy
function.Netmap contract have mandatory system config update and it requires specific arguments format for update function.
frostfs-contract/netmap/netmap_contract.go
Lines 74 to 93 in 4f3c08f
It looks to me as outdated code and it would be nice to have more flexibility in update arguments format for netmap contract. So my propose is to move
if isUpdate
branch before argument parsing andsetConfig
call.The text was updated successfully, but these errors were encountered: