Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle text changes when phantom completion is visible #52

Open
timfjord opened this issue Aug 17, 2022 · 2 comments · May be fixed by #62
Open

Handle text changes when phantom completion is visible #52

timfjord opened this issue Aug 17, 2022 · 2 comments · May be fixed by #62
Labels
enhancement New feature or request phantom Phatom related stuff

Comments

@timfjord
Copy link
Collaborator

Currently, when a phantom completion is displayed typing characters that match the beginning of the ghost text hides the completion and instantiates a new request.

This can be improved and the currently displayed ghost text can be updated without triggering a new request when typed characters match the begging of the ghost text
@timfjord timfjord added enhancement New feature or request phantom Phatom related stuff labels Aug 17, 2022
@timfjord timfjord mentioned this issue Aug 17, 2022
Merged
10 tasks
@TerminalFi
Copy link
Owner

I wonder if this could interfere with copilot returning more accurate results. Or different results.

Perhaps we should update the phantom and still request. And if the result doesn't meet the current completion we update.

@timfjord
Copy link
Collaborator Author

As far as I understand, in VSCode they don't do any requests.
At least the status indicator doesn't show anything when you type characters that match the beginning of the ghost text, but I think it is handled on the core level because they use the suggestion API(or what is the official name for it) and it works the same for other completions.

We can do some requests, but I am afraid the experience won't be smooth.
Plus, I don't think that we would see different results there

I would handle this in a follow-up maybe

This was referenced Oct 4, 2022
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request phantom Phatom related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update the phantom while typing TerminalFi/LSP-copilot
2 participants
@timfjord @TerminalFi