Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UT] [BugFix] Fix mv unstable test cases #55998

Merged
merged 3 commits into from
Feb 20, 2025
Merged

[UT] [BugFix] Fix mv unstable test cases #55998

merged 3 commits into from
Feb 20, 2025

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Feb 18, 2025 •
edited
Loading

Why I'm doing:

  1. Fix failed test: testTransparentRewriteWithSetOperators1
  2. Fix possible different active state in leader/follower FE since not trigger edit log after some scheme changes.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@LiShuMing LiShuMing requested a review from a team as a code owner February 18, 2025 06:01
@LiShuMing
Copy link
Contributor Author

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

rebase

✅ Branch has been successfully rebased

@LiShuMing LiShuMing force-pushed the fix_mv_cases branch 2 times, most recently from 7a593d0 to a201c8a Compare February 18, 2025 11:15
@LiShuMing LiShuMing requested a review from a team as a code owner February 18, 2025 11:15
Seaven
Seaven previously approved these changes Feb 19, 2025
View reviewed changes
@LiShuMing
Copy link
Contributor Author

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 19, 2025

rebase

✅ Branch has been successfully rebased

@LiShuMing LiShuMing force-pushed the fix_mv_cases branch 2 times, most recently from 1311d19 to 5897019 Compare February 19, 2025 06:12
@LiShuMing
Fix mv unstable test cases
76ec5f2 
Signed-off-by: shuming.li <[email protected]>
@LiShuMing
fix bugs
e97bd2d 
Signed-off-by: shuming.li <[email protected]>
@LiShuMing
fix bugs
8f21c98 
Signed-off-by: shuming.li <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 55 / 60 (91.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/MaterializedViewTransparentRewriteRule.java 0 1 00.00% [274]
🔵 com/starrocks/alter/AlterMVJobExecutor.java 22 26 84.62% [498, 538, 606, 607]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MvPartitionCompensator.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/OptExpressionDuplicator.java 20 20 100.00% []
🔵 com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/MvPlanContextBuilder.java 11 11 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@satanson satanson enabled auto-merge (squash) February 19, 2025 10:35
@satanson satanson merged commit 107727b into StarRocks:main Feb 20, 2025
56 of 57 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 20, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 20, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 20, 2025
@LiShuMing @mergify
[UT] [BugFix] Fix mv unstable test cases (#55998)
2c9ae56 
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 107727b)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvTimeSeriesRewriteWithOlapTest.java
@mergify mergify bot mentioned this pull request Feb 20, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Feb 20, 2025
@LiShuMing @mergify
[UT] [BugFix] Fix mv unstable test cases (#55998)
c78a90c 
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 107727b)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/MvPlanContextBuilder.java
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvTimeSeriesRewriteWithOlapTest.java
@mergify mergify bot mentioned this pull request Feb 20, 2025
Closed
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Feb 20, 2025
@mergify @LiShuMing
[UT] [BugFix] Fix mv unstable test cases (backport #55998) (#56090)
23ba47a 
Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@satanson satanson satanson approved these changes

@Seaven Seaven Seaven approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@LiShuMing LiShuMing

Labels
3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiShuMing @satanson @Seaven @HangyuanLiu