Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UT] [BugFix] Fix possible NPE querying task_runs schema table #55968

Merged
merged 2 commits into from
Feb 18, 2025
Merged

[UT] [BugFix] Fix possible NPE querying task_runs schema table #55968

merged 2 commits into from
Feb 18, 2025

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Feb 17, 2025 •
edited
Loading

Why I'm doing:

 2025-02-11 15:04:24.414+08:00 ERROR (thrift-server-pool-125|2590) [ProcessFunction.process():49] Internal error processing getTaskRuns
 java.lang.NullPointerException: Cannot invoke "com.starrocks.load.loadv2.InsertLoadJob.getProgress()" because "job" is null
        at com.starrocks.scheduler.TaskRun.getStatus(TaskRun.java:326)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
        at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
        at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
        at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
        at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
        at com.starrocks.scheduler.TaskManager.getMatchedTaskRunStatus(TaskManager.java:615)
        at com.starrocks.catalog.system.information.TaskRunsSystemTable.query(TaskRunsSystemTable.java:192)
        at com.starrocks.service.FrontendServiceImpl.getTaskRuns(FrontendServiceImpl.java:886)
        at com.starrocks.thrift.FrontendService$Processor$getTaskRuns.getResult(FrontendService.java:5617)
        at com.starrocks.thrift.FrontendService$Processor$getTaskRuns.getResult(FrontendService.java:5594)
        at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:40)
        at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:40)
        at com.starrocks.common.SRTThreadPoolServer$WorkerProcess.run(SRTThreadPoolServer.java:311)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:840)

What I'm doing:

  • Avoid NPE in getTaskRunStatus

Fixes https://github.com/StarRocks/StarRocksTest/issues/9219

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@github-actions github-actions bot added the 3.4 label Feb 17, 2025
@LiShuMing
Copy link
Contributor Author

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 17, 2025

rebase

✅ Branch has been successfully rebased

@LiShuMing LiShuMing force-pushed the fix_task_runs_schema_table branch from a676e05 to 8db433b Compare February 17, 2025 11:36
@LiShuMing LiShuMing changed the title [BugFix] Fix possible NPE querying task_runs schema table [UT] [BugFix] Fix possible NPE querying task_runs schema table Feb 17, 2025
@LiShuMing
Copy link
Contributor Author

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

rebase

✅ Branch has been successfully rebased

@LiShuMing LiShuMing force-pushed the fix_task_runs_schema_table branch from 8db433b to a1ee5eb Compare February 18, 2025 04:49
@LiShuMing
Copy link
Contributor Author

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

rebase

✅ Branch has been successfully rebased

@LiShuMing LiShuMing force-pushed the fix_task_runs_schema_table branch from a1ee5eb to 559fb40 Compare February 18, 2025 08:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 23 / 26 (88.46%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/TaskRun.java 22 25 88.00% [328, 350, 355]
🔵 com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java 1 1 100.00% []

@LiShuMing LiShuMing merged commit 2552759 into StarRocks:main Feb 18, 2025
65 checks passed
@LiShuMing LiShuMing deleted the fix_task_runs_schema_table branch February 18, 2025 11:18
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Feb 18, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 18, 2025
@LiShuMing @mergify
[UT] [BugFix] Fix possible NPE querying task_runs schema table (#55968)
20db774 
Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 2552759)
@mergify mergify bot mentioned this pull request Feb 18, 2025
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Feb 18, 2025
@mergify @LiShuMing
[UT] [BugFix] Fix possible NPE querying task_runs schema table (backp…
684a4e0 
…ort #55968) (#56009)

Co-authored-by: shuming.li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@satanson satanson satanson approved these changes

@murphyatwork murphyatwork murphyatwork approved these changes

Assignees

@LiShuMing LiShuMing

Labels
3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiShuMing @satanson @murphyatwork