Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Fix CNVD-C-2024-1042080 #55919

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Astralidea
Copy link
Contributor

Why I'm doing:

The /api/query_detail endpoint requires authentication because it contains detailed query information, which is considered sensitive. To ensure security, Basic Auth authentication is added to this endpoint.

What I'm doing:

Add Basic Auth to /api/query_detail.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: Astralidea <[email protected]>
@Astralidea Astralidea enabled auto-merge (squash) February 14, 2025 10:15
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Astralidea Astralidea merged commit f6ac330 into StarRocks:main Feb 14, 2025
49 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Feb 14, 2025
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Feb 14, 2025
Copy link
Contributor

mergify bot commented Feb 14, 2025

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Feb 14, 2025

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 14, 2025
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit f6ac330)
mergify bot pushed a commit that referenced this pull request Feb 14, 2025
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit f6ac330)
wanpengfei-git pushed a commit that referenced this pull request Feb 14, 2025
wanpengfei-git pushed a commit that referenced this pull request Feb 14, 2025
liaowanyou pushed a commit to liaowanyou/starrocks that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants