Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure failures at details modifications are recoverable #45

Open
1 task done
Supereg opened this issue Aug 31, 2024 · 1 comment
Open
1 task done

Ensure failures at details modifications are recoverable #45

Supereg opened this issue Aug 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Supereg
Copy link
Member

Supereg commented Aug 31, 2024

Problem

Several async calls have to complete such that an account detail modification is considered successful.

  1. Updating the email address.
  2. Updating the password.
  3. Updating the display name.
  4. Update externally stored account details.

The update might fail at any step and results that a modification is only partially applied. At the same time, we account details are never refreshed. Partial updates are persisted in the service-side, but never display on the client-side.

Solution

There is generally no good approach to revert updates that have already been applied. Therefore, the best solution is probably just to ensure that updated details are properly displayed to the user.

Additional context

This is not a problem in practice, as these combinations never happen in practice. The Account Overview UI either updates the email, password and display name individually or all externally stored details at the same time.

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@Supereg Supereg added the enhancement New feature or request label Aug 31, 2024
@PSchmiedmayer
Copy link
Member

@Supereg Thank you for documenting this! I agree; we shouldn't bother to try to revert any changes. I would also suggest to transparently display any updated values and keep any non-updated values as they are so the user has a up-to-date overview of the account details. An error alert saying that certain fields could not be updated could be part of the UI flows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants