From cbc049c3c01d49ec0f4aeaa8702c9d375ef7145d Mon Sep 17 00:00:00 2001 From: jonaszmclaren Date: Thu, 17 Aug 2017 13:16:24 +0200 Subject: [PATCH] Change 'popup' case to 'pop' I changed the case name 'popup' to 'pop', since it's the name of the method on UINavigationController. Popup is something different (e.g. an ad: https://en.wikipedia.org/wiki/Pop-up_ad) and that name can be misleading. --- LightRoute/LightRoute.swift | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/LightRoute/LightRoute.swift b/LightRoute/LightRoute.swift index 0cbe9c0..307779f 100644 --- a/LightRoute/LightRoute.swift +++ b/LightRoute/LightRoute.swift @@ -198,8 +198,8 @@ public enum TransitionNavigationStyle { /// This case performs that current transition must be push. case push - /// This case performs that current transition must be popup. - case popup + /// This case performs that current transition must be pop. + case pop /// This case performs that current transition must be present. case present @@ -320,7 +320,7 @@ public final class TransitionPromise { } switch navCase { - case .popup: + case .pop: navController.popToViewController(destination, animated: animated) case .present: navController.present(destination, animated: animated, completion: nil)