Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring CORS policy #1

Open
itaym2 opened this issue Mar 12, 2018 · 1 comment
Open

Allow configuring CORS policy #1

itaym2 opened this issue Mar 12, 2018 · 1 comment

Comments

@itaym2
Copy link
Contributor

itaym2 commented Mar 12, 2018

Currently airbag allows CORS requests from any origin, and CORS support is on by default.
We should allow service developers to turn off or configure the CORS policy.
I suggest we add the following configuration options:

  1. ENABLE_CORS - default is false. Must be set to true in order for CORS to work
  2. ALLOWED_ORIGINS - default is none. Should be set to '*' to support all origins, or to a list of allowed origins
@omerlh
Copy link
Contributor

omerlh commented Mar 12, 2018

LGTM. I think this capability should not be part of airbag in the future, but part of a different sidecare...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itaym2 @omerlh