Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AutoHotKey scripts by creating consistent tabindex hierarchy #92

Open
JakubKoralewski opened this issue Aug 12, 2020 · 3 comments
Labels

Comments

@JakubKoralewski
Copy link

Feature request

Currently the behavior when you open the extension panel (Ctrl+Shift+F) and try pressing TAB is very weird and inconsistent.
I propose for the search to be the first element to be highlighted by first tab press; i.e. setting it to tabindex=0.

Why

This would allow scripting with AutoHotKey to open Firefox, then press Ctrl+Shift+F, then TAB, then write the name of the session, then press TAB again to select the first found session, then open the session with something like Ctrl+Enter.

@JakubKoralewski JakubKoralewski changed the title [FEATURE] Support AutoHotKey scripts by creating consisten TAB accessibility settings [FEATURE] Support AutoHotKey scripts by creating consistent tabindex hierarchy Aug 12, 2020
@ReDEnergy
Copy link
Owner

Now I understand why tab might be important. Not 100% sure how to design it but I will consider this idea.

@ReDEnergy ReDEnergy changed the title [FEATURE] Support AutoHotKey scripts by creating consistent tabindex hierarchy Support AutoHotKey scripts by creating consistent tabindex hierarchy Aug 12, 2020
@JakubKoralewski
Copy link
Author

JakubKoralewski commented Aug 12, 2020

Not 100% sure how to design it

Assuming the cause of #91 is fixed (I dunno why options would open when pressing tab) then, when creating the search element, create it with the attribute tabindex equal to 0, then when filtering results, loop over the sessions and using i as the loop iteration count set the sessions' tabindex value to i+1, and also for each filtered session add a keypress event listener, check if ctrl is pressed and Enter is the value of the key, then open the session. I think that's it.

@ReDEnergy
Copy link
Owner

ReDEnergy commented Aug 12, 2020

Maybe when I do that the problem from #91 will be fixed. Because it seems to be something automatically created by how Firefox handles the HTML i write and certainly not because I handle tab press in any way because I don't do that right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants