Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for pathlib chmod setting insecure permissions #1042

Open
costaparas opened this issue Aug 16, 2023 · 0 comments · May be fixed by #1043
Open

Account for pathlib chmod setting insecure permissions #1042

costaparas opened this issue Aug 16, 2023 · 0 comments · May be fixed by #1043
Labels
enhancement New feature or request

Comments

@costaparas
Copy link
Contributor

The current implementation of B103: set_bad_file_permissions works well for uses of the chmod functions from the os module directly.

It fails to report insecure permissions when the equivalent functions from the pathlib module are being used instead.

As a simple example, consider:

import pathlib

p = pathlib.Path("dummy_file")
p.chmod(0o666)

This should trigger an equivalent warning just as os.chmod("dummy_file", 0o666) currently does.

The code should be generalized to support the pathlib version of the chmod functions as well.
@costaparas costaparas added the enhancement New feature or request label Aug 16, 2023
costaparas added a commit to costaparas/bandit that referenced this issue Aug 16, 2023
@costaparas
Add file permission check for pathlib chmod
a9aad84 
This extends the existing implementation for detecting
bad file permissions to account for calls to pathlib
module functions in addition to those from the os module.

The pathlib chmod and lchmod functions are really just
wrappers around the os module equivalents. However, since
they are class methods, the pre-existing logic in the
code did not consider the corresponding pathlib function calls.

Note that the filename is not easily parsable in the case of pathlib.

Closes PyCQA#1042
costaparas added a commit to costaparas/bandit that referenced this issue Aug 16, 2023
@costaparas
Add file permission check for pathlib chmod
91b2179 
This extends the existing implementation for detecting
bad file permissions to account for calls to pathlib
module functions in addition to those from the os module.

The pathlib chmod and lchmod functions are really just
wrappers around the os module equivalents. However, since
they are class methods, the pre-existing logic in the
code did not consider the corresponding pathlib function calls.

Note that the filename is not easily parsable in the case of pathlib.

Resolves PyCQA#1042
@costaparas costaparas linked a pull request Aug 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add file permission check for pathlib chmod costaparas/bandit
1 participant
@costaparas