Implement NavigateFromAsync method without recreating a page. #3182

niimima · 2024-07-05T07:57:04Z

Description of Change

Adding NavigateFromAsync methods without recreating a page.

Bugs Fixed

fixes [Enhancement] NavigateFrom #3118

API Changes

List all API changes here (or just put None),

Added:

Task INavigationService.NavigateFromAsync(string viewName, Uri route, INavigationParameters parameters);
Task INavigationServiceExtensions.NavigateFromAsync(this INavigationService navigationService, string viewName, Uri route)

Behavioral Changes

No changes. Only additions of features.

PR Checklist

Has tests (if omitted, state reason in description)
Rebased on top of master at time of PR
Changes adhere to coding standard

niimima · 2024-07-05T08:06:11Z

I have a concern regarding the pull request I've created. When searching for a page using viewName, if it is not found, what would be the recommended behavior?
https://github.com/PrismLibrary/Prism/pull/3182/files#diff-8ae9340c7f10510f59a045175866a15bdb8ed35b541c8256cf73252dafadc343R350-R356

In the current implementation, pages specified by route appears directly under the window.

AmrAlSayed0 · 2024-07-07T08:09:01Z

src/Maui/Prism.Maui/Navigation/PageNavigationService.cs

+            {
+                if (page is not null && ViewModelLocator.GetNavigationName(page) == viewName)
+                    break;
+                page = page.GetParentPage();


Parent page? Shouldn't this be the page before the current page in the stack and if it is the root page then we get the parent page?

@AmrAlSayed0 is correct. While we do care about the parent in some scenarios, what we really need is the previous page in the navigation stack.

There are still some issues remaining, but I have made corrections to use the NavigationStack as described in the following link.

Prism/src/Maui/Prism.Maui/Navigation/PageNavigationService.cs

Lines 351 to 383 in 7f8a12f

// Find a page that matches the viewName.

var currentPage = GetCurrentPage();

var navigationPages = currentPage.Navigation.NavigationStack.ToList();

navigationPages.Reverse();

var foundPage = navigationPages.FirstOrDefault(page => ViewModelLocator.GetNavigationName(page) == viewName);

if (foundPage is null)

{

// Find a page from parents.

var page = currentPage;

while (page != null)

{

if (page is not null && ViewModelLocator.GetNavigationName(page) == viewName)

break;

page = page.GetParentPage();

}

currentPage = page;

}

else

{

// Insert RemovePageSegment.

var removePageCount = navigationPages.IndexOf(foundPage);

var tempQueue = new Queue<string>();

for (int i = 0; i < removePageCount; i++)

{

tempQueue.Enqueue(RemovePageSegment);

}

while(navigationSegments.Count > 0)

{

tempQueue.Enqueue(navigationSegments.Dequeue());

}

navigationSegments = tempQueue;

}

brianlagunas · 2024-07-09T18:19:48Z

This PR is not performing the actions required of the issue. Per the issue

This API should then effectively do the same as ../../SomePage where the ../.. is replaced by going back until we found the View that was specified.

This means you must first find the page, while keeping track of the number of times we must navigate back until we reach this page, and then begin navigating forward from there.

Decisions must also be made as to whether this can be supported in both a modal and non-modal navigation stack. While also considering the page's parent such as a TabbedPage or FlyoutPage

This reverts commit 5af4754.

niimima · 2024-07-29T08:23:19Z

@brianlagunas

This PR is not performing the actions required of the issue. Per the issue

This API should then effectively do the same as ../../SomePage where the ../.. is replaced by going back until we found the View that was specified.

This means you must first find the page, while keeping track of the number of times we must navigate back until we reach this page, and then begin navigating forward from there.

Decisions must also be made as to whether this can be supported in both a modal and non-modal navigation stack. While also considering the page's parent such as a TabbedPage or FlyoutPage

Thank you for your feedback. Firstly, I am working on ensuring that the navigation works correctly with both TabbedPage and FlyoutPage. The FlyoutPage seems to be working well, but I need to confirm the specifications for the TabbedPage.

In the existing NavigateAsync method, you can use KnownNavigationParameters to either create or select a tab. For the NavigateFromAsync method, which approach would be more appropriate? Or, would it be better to dynamically switch between creating and selecting tabs based on the situation?

niimima added 2 commits July 5, 2024 16:12

[WIP] Add NavigateFromAsync methods and unittests.

6ee0fa4

Modify NavigateFromAsync method and unittests.

86b68a5

AmrAlSayed0 reviewed Jul 7, 2024

View reviewed changes

dansiegel added this to the vNext milestone Jul 19, 2024

Modifies NavigateFromAsync to use navigationStack

41b3270

niimima requested a review from dansiegel as a code owner July 29, 2024 02:22

niimima added 5 commits July 29, 2024 13:59

Modify NavigateFromAsync to find parent pages

e1a4cf5

Modify UnitTest

b1dcfc2

Modify GetParentPage access modifier

5af4754

Revert "Modify GetParentPage access modifier"

a33db2f

This reverts commit 5af4754.

Refactor insert RemovePageSegment

7f8a12f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement NavigateFromAsync method without recreating a page. #3182

Implement NavigateFromAsync method without recreating a page. #3182

niimima commented Jul 5, 2024 •

edited

Loading

niimima commented Jul 5, 2024 •

edited

Loading

AmrAlSayed0 Jul 7, 2024

brianlagunas Jul 9, 2024

niimima Jul 29, 2024

brianlagunas commented Jul 9, 2024

niimima commented Jul 29, 2024

	// Find a page that matches the viewName.
	var currentPage = GetCurrentPage();
	var navigationPages = currentPage.Navigation.NavigationStack.ToList();
	navigationPages.Reverse();
	var foundPage = navigationPages.FirstOrDefault(page => ViewModelLocator.GetNavigationName(page) == viewName);
	if (foundPage is null)
	{
	// Find a page from parents.
	var page = currentPage;
	while (page != null)
	{
	if (page is not null && ViewModelLocator.GetNavigationName(page) == viewName)
	break;
	page = page.GetParentPage();
	}
	currentPage = page;
	}
	else
	{
	// Insert RemovePageSegment.
	var removePageCount = navigationPages.IndexOf(foundPage);

	var tempQueue = new Queue<string>();
	for (int i = 0; i < removePageCount; i++)
	{
	tempQueue.Enqueue(RemovePageSegment);
	}
	while(navigationSegments.Count > 0)
	{
	tempQueue.Enqueue(navigationSegments.Dequeue());
	}
	navigationSegments = tempQueue;
	}

Implement NavigateFromAsync method without recreating a page. #3182

Are you sure you want to change the base?

Implement NavigateFromAsync method without recreating a page. #3182

Conversation

niimima commented Jul 5, 2024 • edited Loading

Description of Change

Bugs Fixed

API Changes

Behavioral Changes

PR Checklist

niimima commented Jul 5, 2024 • edited Loading

AmrAlSayed0 Jul 7, 2024

Choose a reason for hiding this comment

brianlagunas Jul 9, 2024

Choose a reason for hiding this comment

niimima Jul 29, 2024

Choose a reason for hiding this comment

brianlagunas commented Jul 9, 2024

niimima commented Jul 29, 2024

niimima commented Jul 5, 2024 •

edited

Loading

niimima commented Jul 5, 2024 •

edited

Loading