Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop adding EUMM to build requires #45

Open
karenetheridge opened this issue Jun 5, 2015 · 2 comments
Open

stop adding EUMM to build requires #45

karenetheridge opened this issue Jun 5, 2015 · 2 comments

Comments

@karenetheridge
Copy link
Member

EUMM is not needed to run 'make' - there is no reason why MI should be populating build-requires at all.

@haarg
Copy link
Member

haarg commented Jun 5, 2015

EUMM is needed by various parts of the Makefile, and it adds itself to build requires. There isn't really any harm in doing this, although it also isn't much help because it's too late for the prereq to be satisfied.

@miyagawa
Copy link
Member

miyagawa commented Jun 5, 2015

Actually, MakeMaker puts itself to "build" too, even if MI stops doing that. (I just tested with a plain Makefile.PL with WriteMakefile() call)

➜ cat Makefile.PL 
use ExtUtils::MakeMaker;
WriteMakefile(NAME => "Foo");
➜  perl Makefile.PL 
Generating a Unix-style Makefile
Writing Makefile for Foo
Writing MYMETA.yml and MYMETA.json
➜  grep -3 build MYMETA.json
      ]
   },
   "prereqs" : {
      "build" : {
         "requires" : {
            "ExtUtils::MakeMaker" : "0"
         }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants