Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace FluentAssertions with Shouldly or AwesomeAssertions #2431

Closed
IhateTrains opened this issue Jan 16, 2025 · 0 comments · Fixed by #2432
Closed

Replace FluentAssertions with Shouldly or AwesomeAssertions #2431

IhateTrains opened this issue Jan 16, 2025 · 0 comments · Fixed by #2432
Labels
dependencies Pull requests that update a dependency file

Comments

@IhateTrains
Copy link
Member

IhateTrains commented Jan 16, 2025 •
edited
Loading

https://www.reddit.com/r/programming/comments/1i19l11/fluent_assertion_sneakily_changed_from_apache_20/
FluentAssertions 8.0 comes with a new license. So, instead of upgrading to it, we should migrate to Shoudly once it has a new version released.
An altenative is https://github.com/AwesomeAssertions/AwesomeAssertions, an Apache 2.0 fork of FluentAssertions.
@IhateTrains IhateTrains changed the title Replace FluentAssertions with Shouldy Replace FluentAssertions with Shouldly Jan 16, 2025
@IhateTrains IhateTrains changed the title Replace FluentAssertions with Shouldly Replace FluentAssertions with Shouldly or AwesomeAssertions Jan 16, 2025
@IhateTrains IhateTrains mentioned this issue Jan 16, 2025
Merged
@IhateTrains IhateTrains added the dependencies Pull requests that update a dependency file label Jan 20, 2025
IhateTrains added a commit that referenced this issue Jan 22, 2025
@IhateTrains @tanner918 @code-factor
Rajas of Asia support (#2432) #minor
4b91655 
closes #2431 
closes #2404

---------

Co-authored-by: tanner918 <[email protected]>
Co-authored-by: codefactor-io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rajas of Asia support ParadoxGameConverters/ImperatorToCK3
1 participant
@IhateTrains