Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir style guide and identifier names #3

Open
tmbb opened this issue Jul 26, 2017 · 3 comments
Open

Elixir style guide and identifier names #3

tmbb opened this issue Jul 26, 2017 · 3 comments

Comments

@tmbb
Copy link
Contributor

tmbb commented Jul 26, 2017

The function repeatFn should be renamed to repeat_fn according to the elixir style guide.

@OvermindDL1
Copy link
Owner

OvermindDL1 commented Jul 26, 2017

The function repeatFn should be renamed to repeat_fn according to the elixir style guide.

Yeah I was doing too much coding in other languages at the time and it leaked over.... ^.^;

That will be a breaking change though so I'll wait for that on a major version bump, leaving this open for now to remind me (I'll probably have both in a minor bump then remove the repeatFn one on a major bump).

@tmbb
Copy link
Contributor Author

tmbb commented Jul 26, 2017

There are some other identifiers no written according to the elixir style guide that aren't user-visible. I might submit a PR one of these days.

@OvermindDL1
Copy link
Owner

There are some other identifiers no written according to the elixir style guide that aren't user-visible. I might submit a PR one of these days.

That'd be cool, just keep the old names for now too but mark them as deprecated for later removal. :-)
At the very least if you want to document them all that would be great, or I can use a regex over it sometime like [a-z]+[A-Z] to find them. ^.^

@tmbb tmbb changed the title Elixir stile guide and identifier names Elixir style guide and identifier names Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants