Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set properties in maven-failsafe-plugin configuration #63

Open
hantsy opened this issue Feb 7, 2020 · 4 comments
Open

Allow set properties in maven-failsafe-plugin configuration #63

hantsy opened this issue Feb 7, 2020 · 4 comments

Comments

@hantsy
Copy link

hantsy commented Feb 7, 2020

I tried to set liberty properties(wlpHome) in maven-failsafe-plugin configuration like what I have done in wildfly configuration. But it seems it does not support.

I hope all liberty properties can be configured via environmentVariables and systemProperties, eg in maven-failsafe-plugin or maven-surefire-plugin, or system properties(can be overriden by Maven args) and make the properties config in arquillian.xml is optional.

<configuration>
                            <environmentVariables>
                                <WLP_HOME>${project.build.directory}/wlp</WLP_HOME>
                            </environmentVariables>
                            <systemProperties>
                                <wlpHome>${project.build.directory}/wlp</wlpHome>
                            </systemProperties>
                        </configuration>
@chyt
Copy link
Contributor

chyt commented Feb 10, 2020

We don't support setting configuration in this manner. You can use the configure-arquillian goal in the Liberty Maven Plugin if you wish for the plugin to auto-generate your arquillian.xml based on the managed server instance.

@hantsy
Copy link
Author

hantsy commented Feb 11, 2020

Liberty Maven Plugin 's configure-arquillian goal is generating an arquillian.xml file, what I request is there is no need to add arquillian.xml at all.

I hope all liberty properties can be configured via environmentVariables and systemProperties, eg in maven-failsafe-plugin or maven-surefire-plugin, or system properties(can be overriden by Maven args) and make the properties config in arquillian.xml is optional.

What developers need is Convention over configuartion.

I have some codes, just need to make it read the properties from the system properties firstly.

@chyt
Copy link
Contributor

chyt commented Feb 11, 2020

Is there some prerequisite to this within the scope of Arquillian containers? The arquillian.xml is a construct required by any Arquillian container implementations, not just for the Liberty server. I'm pretty sure there's some arquillian.xml validation that takes place before our container is even given control within the testing lifecyle.

For example, the arquillian.xml supports the definition of configuration for multiple containers, something that is beyond the scope of just the Arquillian Liberty container implementations. Again, unless there is some change in the convention of Arquillian to make arquillian.xml optional I'm not sure how we can avoid it.

@hantsy
Copy link
Author

hantsy commented Feb 12, 2020

OK, I just tried Openliberty for a JakarataEE compatible server, personally I am not a big fan of Openliberty. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants