Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for google sign in #96

Closed
wants to merge 2 commits into from

Conversation

Vaishali785
Copy link

@Vaishali785 Vaishali785 commented Oct 8, 2023

Purpose ✨

Added google sign in option
Fixes #65

Details πŸ“

  1. Create one account on google cloud console and create oauth consent screen and set up your credentials using Oauth client Id
  2. Copy client Id from here and use it in the index.js file.
  3. Added one route in App.js 'login2' just for demo purpose, you can check the sign in functionality here and then remove this route.
  4. All the code related to this sign process is in googleAuth.js which is in src/components folder.
  5. I've adde the functionality here, you can style it as per your convenience.
  6. I'd added one button in SignIn.js file also, it was just for UI, it is not functional. So you can remove it if you want.

Dependencies πŸ”—

Used one package called "@react-oauth/google", version "0.11.1".

Future Improvements πŸ”­

Mentions πŸ‘€

@krishnan05

Screenshots of relevant screens πŸ“Έ

Screenshot 2023-10-09 at 1 37 27 AM Screenshot 2023-10-09 at 1 43 28 AM Screenshot 2023-10-09 at 1 38 20 AM

Developer's checklist πŸ“ƒ

  • Followed the coding guidelines.
  • Properly commented the code.
  • No print statements in the code.
    Two console.log are present for printing error.
  • All the functionalities are working properly.
  • Changes made are not breaking any other part of the project.
  • No UI/UX issues are present.
  • Relevant screenshots are added in the PR.
  • Followed the PR guidelines

@Aditya062003
Copy link
Contributor

Aditya062003 commented Oct 14, 2023

It seems like there's an issue with authentication on the /login2 route, as it's displaying the home screen UI without proper authentication. To fix this, you'll need to ensure that the /login2 route enforces authentication before granting access to the home screen and leaderboards. Kindly, Check your authentication logic and make sure it's correctly implemented.

@Vaishali785
Copy link
Author

It seems like there's an issue with authentication on the /login2 route, as it's displaying the home screen UI without proper authentication. To fix this, you'll need to ensure that the /login2 route enforces authentication before granting access to the home screen and leaderboards. Kindly, Check your authentication logic and make sure it's correctly implemented.

Can you please attach a screenshot what is visible to you on /login2 route? And mark the part which should not be there.

@krishnan05 krishnan05 closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Auth
3 participants