Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between this project and upstart-commers/sbt-openapi-generator #16

Open
ashleymercer opened this issue Aug 1, 2020 · 4 comments

Comments

@ashleymercer
Copy link

ashleymercer commented Aug 1, 2020

Hi all,

What are the differences between this project and upstart-commerce/sbt-openapi-generator, and which is recommended? It looks like they have separate histories (reading this ticket) so would it make sense to combine efforts under a single official plugin?

Thanks :)

@ashleymercer ashleymercer changed the title Difference between this project and Difference between this project and upstart-commers/sbt-openapi-generator Aug 1, 2020
@JFCote
Copy link
Member

JFCote commented Oct 30, 2020

👀 I'm interested to know that too.

@jimschubert
Copy link
Member

I'm not entirely sure what is going on with that repo.

My understanding from OpenAPITools/openapi-generator#3650 is that @YanDoroshenko and @chameleon82 were working to collaborate on Yan's implementation from that repository. There was a comment that the implementation from https://github.com/adenza/sbt-openapi-generator was considered feature complete, and that was the version presented in this repo.

To be honest, this plugin is a very simple wrapper around openapi-generator. It defines keys matching configurations that we have in the gradle wrapper, then just executes generation through openapi-generator as all other interfaces (CLI, build plugins, IDE plugins) do using CodegenConfigurator.

This project is different in that it also includes tasks for listing generators and performing generation. Because our generate task returns Def.Initialize[Task[Seq[File]]], SBT can keep track of file outputs from that task. The upstart-commerce version doesn't do this.

I know I'm biased, but even if I wasn't an OpenAPI Tools contributor, I'd choose this one for the file returns and SBT optimization that allows (see https://www.scala-sbt.org/1.x/docs/Howto-Track-File-Inputs-and-Outputs.html#File+outputs)

@chameleon82
Copy link
Contributor

Unfortunately @YanDoroshenko never reached me back and it is not clear about releasing cycle and future of https://github.com/upstart-commerce/sbt-openapi-generator (last activity 13 months ago)
One more reason is to have sbt-plugin maintained by community.

@JFCote
Copy link
Member

JFCote commented Feb 3, 2021

@jimschubert Thank you for this explanation. I will definitely try this plugin in the near future because one of our project is using SBT (with play framework) and we currently use a .sh file with the .jar which is far for ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants