Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[octomap_server] Filtering In Map Frame #82

Open
mohdomama opened this issue Jan 19, 2021 · 2 comments · May be fixed by #83
Open

[octomap_server] Filtering In Map Frame #82

mohdomama opened this issue Jan 19, 2021 · 2 comments · May be fixed by #83

Comments

@mohdomama
Copy link

mohdomama commented Jan 19, 2021 •
edited
Loading

Hi,
With filter_ground as false, the filtering done with pointcloud_min_z and pointcloud_max_z happens in the map frame. I think the desired behavior would be to do this filtering in base_link frame.

Note: When filter_ground is true, all filtering happens in base_link frame.

octomap_mapping/octomap_server/src/OctomapServer.cpp

Line 330 in bd66bc1

pcl::transformPointCloud(pc, pc, sensorToWorld);

@mohdomama mohdomama linked a pull request Jan 20, 2021 that will close this issue
Open
@ahornung
Copy link
Member

I think there are valid use cases for both scenarios. Ideally, there is a parameter for the filter frame.

@mohdomama
Copy link
Author

Hi,
Thanks for the reply. Should I add a parameter for this?

Also, when doing filtering with filter_ground as false, the points outside the filter are not cleared. This issue is apparent when we have dynamic objects in the scene. The entire trail of the object comes as occupied.
I addressed this issue in the PR by marking the points outside the filter as pc_ground which then get cleared in insertScan function. Is this approach acceptable or should there be some other workaround for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[octomap_server] Filtering In Base Frame Instead of Map Frame mohdomama/octomap_mapping
2 participants
@ahornung @mohdomama