Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to read 2 datastores with different purposes. #125

Open
valentina-s opened this issue Aug 20, 2024 · 0 comments
Open

Provide an option to read 2 datastores with different purposes. #125

valentina-s opened this issue Aug 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@valentina-s
Copy link
Collaborator

Description

Currently the pipeline.yaml configuration provides an option to read two paths with the datastore option. However, if two paths are passed the code goes into the steps needed to parse the two frequencies of Lasker, and that is a very specific scenario. In the context of echoshader_flow_predictions, it needs to also process

Expected Behavior

Ideally we should be able to pass several paths and decide what to do with them within the stages. As a starting point we should at least be able to provide an inidicator whether we are dealing with two paths because we want to combine channels for MVBS or we want to combine MVBS with masks.

Actual Behavior

On realtime branch we call a function get_input_from_store_folder. This function checks if there are more than one folders and combines the frequencies so that it works for Lasker.
On echoshader_predictions branch we call a function get_input_from_store_folder_mvbs_score which is combining mvbs and score for echoshade_flow_predictions flow.

The above steps are happening in the initialization_flow.

Possible Solution / Suggestion

A short-term solution is to use keys to indicate if the paths are for MVBS frequency, or score combination.

To run echoshader on Lasker we need to access 3 folders: two MVBS frequency folders and Score folders.

@valentina-s valentina-s added the bug Something isn't working label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants