Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Union{Nothing, Matrix{F}} struct fields parametric #56

Open
JordiBolibar opened this issue May 31, 2024 · 0 comments
Open

Make Union{Nothing, Matrix{F}} struct fields parametric #56

JordiBolibar opened this issue May 31, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JordiBolibar
Copy link
Member

JordiBolibar commented May 31, 2024 •
edited
Loading

In order to avoid issues with mixed types, especially for Enzyme, we should stick to Matrix{F} types for anything related to Glacier2D, SIA2D, etc... This will ensure that the type doesn't change.

The types should be made parametric, i.e. moving them to the function signature instead of individually specifying them in each field.

To be extended to Huginn.jl, Muninn.jl and ODINN.jl.
@JordiBolibar JordiBolibar changed the title Move Union{Nothing, Matrix{} to Move Union{Nothing, Matrix{F}} to Matrix{F} May 31, 2024
@JordiBolibar JordiBolibar added the enhancement New feature or request label May 31, 2024
@JordiBolibar JordiBolibar changed the title Move Union{Nothing, Matrix{F}} to Matrix{F} Make Union{Nothing, Matrix{F}} struct fields parametric May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JordiBolibar