Build with obfuscated bundles #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node doesn't like the name to contain spaces, so we need to get rid of them
simonhamp
changed the title
# Conflicts: # resources/js/electron-plugin/src/server/php.ts
gwleuverink
added a commit
to gwleuverink/nativephp-electron
that referenced
this pull request
Jan 7, 2025
Co-authored-by: Simon Hamp <[email protected]>
gwleuverink
added a commit
to gwleuverink/nativephp-electron
that referenced
this pull request
Jan 7, 2025
Co-authored-by: Simon Hamp <[email protected]>
gwleuverink
added a commit
to gwleuverink/nativephp-electron
that referenced
this pull request
Jan 7, 2025
Co-authored-by: Simon Hamp <[email protected]>
MasterRO94
reviewed
Jan 28, 2025
src/Traits/SetsAppName.php
Outdated
Comment on lines
5
to
7
| use function Laravel\Prompts\intro; | ||
| use function Laravel\Prompts\note; | ||
|
|
MasterRO94
reviewed
Jan 28, 2025
| removeSync(tmpDir); | ||
| let bundle = join(process.env.APP_PATH, 'build', '__nativephp_app_bundle'); | ||
|
|
||
| if (existsSync(bundle)) { |
MasterRO94
reviewed
Jan 28, 2025
Comment on lines
+116
to
+121
| writeJsonSync(join(appPath, 'storage', 'framework', 'cache', '_native.json'), {}) | ||
| writeJsonSync(join(appPath, 'storage', 'framework', 'sessions', '_native.json'), {}) | ||
| writeJsonSync(join(appPath, 'storage', 'framework', 'testing', '_native.json'), {}) | ||
| writeJsonSync(join(appPath, 'storage', 'framework', 'views', '_native.json'), {}) | ||
| writeJsonSync(join(appPath, 'storage', 'app', 'public', '_native.json'), {}) | ||
| writeJsonSync(join(appPath, 'storage', 'logs', '_native.json'), {}) |
There was a problem hiding this comment.
It's better to use outputJsonSync to create any missing directory in path or add additionall call ensureDirSync, but I prefer outputJsonSync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other half of NativePHP/electron-plugin#36
Fixes NativePHP/laravel#343
Fixes NativePHP/laravel#388