Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Menu Section is closed, after using menu search, section is not opened #51

Open
webard opened this issue Mar 7, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@webard
Copy link
Contributor

webard commented Mar 7, 2024

Hello,

When I search in menu and founded item is in closed section, this section won't open:

image
@webard webard added the bug Something isn't working label Mar 7, 2024
@Muetze42
Copy link
Owner

Muetze42 commented Mar 8, 2024

I can't reproduce it.

Should closed menus open when they are closed?

@webard
Copy link
Contributor Author

webard commented Mar 8, 2024

Should closed menus open when they are closed?

I think yes, closed menu, if search condition is met for it's resources, should be opened.

@Muetze42
Copy link
Owner

Muetze42 commented Mar 8, 2024

Hmm. I'd have to think about that.

The filter is in the MainMenu component and MenuGroup and MenuSection are collapsible.
https://github.com/Muetze42/nova-menu/tree/main/resources/js/components

Whether a menu is open or closed is determined by values in the local storage and not by CSS...

@webard
Copy link
Contributor Author

webard commented Mar 8, 2024

Thank you. I think this feature should enhance overall user experience with menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants