Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary Reader does not accept empty newlines at EOF #64

Open
Milo-D opened this issue Mar 30, 2021 · 0 comments · May be fixed by #74
Open

Binary Reader does not accept empty newlines at EOF #64

Milo-D opened this issue Mar 30, 2021 · 0 comments · May be fixed by #74
Assignees
@Milo-D
Labels
bug Something isn't working info

Comments

@Milo-D
Copy link
Owner

Milo-D commented Mar 30, 2021

Currently the binary reader will return failure (illegal symbols in hex file) on newlines at end of file.

This exception can be avoided by removing the newline at end of file. Usually, gcc and avra do not create newlines at EOF, so there should not be a problem with binaries created by tools like gcc.
@Milo-D Milo-D added bug Something isn't working info labels Mar 30, 2021
@Milo-D Milo-D self-assigned this Mar 30, 2021
pointbazaar added a commit to pointbazaar/libvmcu-Virtual-MCU-Library that referenced this issue Dec 19, 2024
@pointbazaar
Ignore non-record chars in .ihex files
7657f02 
[1] -> Format -> Record Structure -> 1
describes that each line contains a record.

The record starts with ':' and
"All characters preceding this symbol in a record should be ignored".

Search for that char in the line and continue to the next line if it is
not found.

resolves Milo-D#64

References:
  [1] https://en.wikipedia.org/wiki/Intel_HEX
@pointbazaar pointbazaar linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Milo-D Milo-D

Labels
bug Something isn't working info
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore non-record chars in .ihex files pointbazaar/libvmcu-Virtual-MCU-Library
1 participant
@Milo-D