Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions for platform-specific features should not show up on other platforms #86

Open
sanketj opened this issue May 3, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sanketj
Copy link
Member

sanketj commented May 3, 2019

For extensions that target platform-specific features, like WinD3D11AngleTextures or TSFTextStore, we should come up with a declarative way to tag them as platform-specific and "hide" them on other platforms. The "targetModules" field in the extension manifest achieves this for extensions that are in platform-specific modules. But for situations where the extension targets a generic module, like msedge_child or chrome_child, this doesn't work. One option is to add a "targetPlatforms" field to the extension manifest.

@sanketj sanketj added enhancement New feature or request good first issue Good for newcomers labels May 3, 2019
@cbiesinger
Copy link
Collaborator

I wonder if you could achieve some of this with a "requireModule" attribute. For windows, specify ntdll, for linux, maybe "c" or "gtk". I'm sure mac has something.

@sanketj
Copy link
Member Author

sanketj commented May 3, 2019

I wonder if you could achieve some of this with a "requireModule" attribute. For windows, specify ntdll, for linux, maybe "c" or "gtk". I'm sure mac has something.

Yes, that is one way to detect which platform the user is currently debugging on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants
@cbiesinger @sanketj and others